Hi Laurent, On Mon, Sep 17, 2018 at 11:09 AM Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > On Monday, 17 September 2018 11:51:06 EEST Simon Horman wrote: > > On Mon, Sep 17, 2018 at 11:38:43AM +0300, Laurent Pinchart wrote: > > > On Monday, 17 September 2018 10:50:55 EEST Simon Horman wrote: > > > > On Fri, Sep 14, 2018 at 12:10:43PM +0300, Laurent Pinchart wrote: > > > > > The R8A77990 (E3) platform has one RGB output and two LVDS outputs > > > > > connected to the DU. Add the DT nodes for the DU, LVDS encoders and > > > > > supporting VSP and FCP. > > > > > > > > > > Signed-off-by: Laurent Pinchart > > > > > <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > > > > Tested-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> > > > > > --- > > > > > > > > > > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 167 +++++++++++++++++++++ > > > > > 1 file changed, 167 insertions(+) > > > > > > > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > > > > > b/arch/arm64/boot/dts/renesas/r8a77990.dtsi index > > > > > abb14af76c0e..600074ca3ee5 100644 > > > > > --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > > > > > +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > > > > > @@ -537,6 +537,173 @@ > > > > > resets = <&cpg 408>; > > > > > }; > > > > > > > > These nodes should be placed after the gic to preserve the sorting > > > > of nodes by bus address and then IP block. > > > > > > Aren't they already ? :-) > > > > Git didn't seem to think so. But its not a big deal, > > I can fix this up locally. > > Did it apply the below hunk to a different location ? 408 is the gic, isn't it > ? The "-U <n>" option (with <n> sufficiently large) of "git diff" and "git show" is a great help for inspecting DT changes. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds