Hi Chris,
On Thu, Sep 6, 2018 at 2:44 PM Chris Brandt <Chris.Brandt@xxxxxxxxxxx> wrote:
> On Thursday, September 06, 2018, Geert Uytterhoeven wrote:
> > > + if (of_device_is_compatible(np, "renesas,r7s9210-wdt"))
> > > + priv->ext_cks = true;
> >
> > That's not the proper way to support multiple devices.
> > Please add an entry for "renesas,r7s9210-wdt" to rza_wdt_of_match[].
> > "renesas,r7s9210-wdt" must be documented in the DT bindings.
> >
> > I suggest storing cks in rza_wdt_of_match[].data, and retrieving it with
> > of_device_get_match_data() in your probe function, so you can use that to
> > differentiate,
>
> OK, I will change to that.
>
> > and get rid of the ext_cks flag.
>
> I still need to keep track if it's a RZ/A1 or RZ/A2 (ext_cks) for
> functions outside of probe (rza_wdt_calc_timeout).
You can check if priv->cks > 7?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
