Hello, On Thursday, 6 September 2018 12:42:32 EEST Simon Horman wrote: > On Thu, Aug 23, 2018 at 11:58:54AM +0200, Geert Uytterhoeven wrote: > > On Sun, Aug 19, 2018 at 9:44 PM Laurent Pinchart wrote: > >> The Salvator-X and XS boards have a 4 lines DIP switch and 3 push > >> buttons connected to SoC GPIOs, meant to be used as general-purpose test > >> keys. Add a corresponding node in DT, mapping (semi-randomly) the DIP > >> switch to keys 1-4 and the push buttons to keys A-C. > >> > >> Signed-off-by: Laurent Pinchart > >> <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > > > Given GP6_1[123] are not just wired to the 3 push buttons, but also to 3 > > LEDs, I wonder if we shouldn't postpone that part until Linux can handle > > GPIOs connected to both? > > Laurent, any thoughts on that? Right now the GPIOs are not wired in DT, and we're thus without a way to interface to both LEDs and push buttons. While I agree that an ideal solution would be to support both, I think that moving from nothing to support for push buttons would be a step forward already. -- Regards, Laurent Pinchart