On Wed, Sep 05, 2018 at 08:52:56AM +0200, Geert Uytterhoeven wrote: > Hi Kaneko-san, > > On Tue, Sep 4, 2018 at 10:23 PM Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> wrote: > > From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > > > This patch adds the device nodes for all MSIOF SPI controllers to > > the R8A77990 SoC. > > > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> > > Thanks for your patch! > > Unfortunately this is a duplicate of > https://www.spinics.net/lists/devicetree/msg246988.html. > > Sorry for stepping on your toes, I added MSIOF support for Ebisu to investigate > MSIOF driver bugs. The DMA portions seem new. Perhaps a new patch should be constructed that only adds those properties? > > > --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > > @@ -14,6 +14,13 @@ > > #address-cells = <2>; > > #size-cells = <2>; > > > > + aliases { > > + spi0 = &msiof0; > > + spi1 = &msiof1; > > + spi2 = &msiof2; > > + spi3 = &msiof3; > > + }; > > The SPI subsystem no longer needs aliases. > Furthermore, aliases complicate DT overlay handling. > > > + > > cpus { > > #address-cells = <1>; > > #size-cells = <0>; > > @@ -70,6 +77,13 @@ > > clock-frequency = <0>; > > }; > > > > + /* MSIOF reference clock - to be overridden by boards that provide it */ > > + msiof_ref_clk: msiof-ref-clock { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <0>; > > + }; > > This clock does not exist. > > Board DTS should use "assigned-clocks" and "assigned-clock-rates" on the > MSO clock instead. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >
