Hi Kaneko-san, On Tue, Sep 4, 2018 at 10:22 PM Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> wrote: > From: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@xxxxxxxxxxx> > > This patch adds support for MSIOF ch2 pinctrl to use the LVDS Control > Connector (CN41) for the Draak board on the R8A77995 SoC. > > Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@xxxxxxxxxxx> > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > [ykaneko0929@xxxxxxxxx: deleted the unused reference to 'msiof_ref_clk'] > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Minor nit below. > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > @@ -371,3 +377,10 @@ > }; > }; > }; > + > +&msiof2 { Please insert following alphabetical order. > + pinctrl-0 = <&msiof2_pins>; > + pinctrl-names = "default"; > + /* In case of using this node, please enable this property */ I think this deserves some explanation about CN41. > + /* status = "okay"; */ > +}; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds