On Fri, Aug 24, 2018 at 09:06:49AM +0000, Fabrizio Castro wrote:
> Hello Simon,
>
> Thank you for your feedback!
>
> > Subject: Re: [PATCH 4/5] arm64: dts: renesas: r8a774a1: Add Ethernet AVB node
> >
> > On Thu, Aug 23, 2018 at 09:58:50AM +0100, Biju Das wrote:
> > > From: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> > >
> > > This patch adds the SoC specific part of the Ethernet AVB
> > > device tree node.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> > > Reviewed-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> > > ---
> > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 45 +++++++++++++++++++++++++++++++
> > > 1 file changed, 45 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > > index 15d7785..b771211 100644
> > > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > > @@ -350,6 +350,51 @@
> > > dma-channels = <16>;
> > > };
> > >
> > > +avb: ethernet@e6800000 {
> > > +compatible = "renesas,etheravb-r8a774a1",
> > > + "renesas,etheravb-rcar-gen3";
> > > +reg = <0 0xe6800000 0 0x800>;
> >
> > Should a region, <0 0xe6a00000 0 0x10000>, also be added
> > here to describe the suggested space for descriptors?
>
> There is no STBE (Stream Buffer for EthernetAVB-IF) on the r8a774a1, and that's why this node doesn't come with such a region.
Thanks for the follow-up. In that case I'm fine with this patch but
I'd like to wait a little longer to allow review by others.
Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
