Hi Laurent and Jacopo, On 2018-08-25 02:54:44 +0300, Laurent Pinchart wrote: > Hi Jacopo, > > On Monday, 20 August 2018 13:16:34 EEST Jacopo Mondi wrote: > > Hello renesas list, > > this series add supports for the HDMI and CVBS input to R-Car E3 R8A77990 > > Ebisu board. > > > > It's an RFT, as I don't have an Ebisu to test with :( > > > > The series adds supports for the following items: > > > > - PFC: add VIN groups and functions > > - R-Car VIN and R-Car CSI-2: add support for R8A77990 > > - R8A77990: Add I2C, VIN and CSI-2 nodes > > - Ebisu: describe HDMI and CVBS inputs > > > > Each patch, when relevant reports difference between the upported BSP patch > > and the proposed one. > > > > I know Laurent should receive an Ebisu sooner or later, maybe we can sync > > for testing :) > > I've given the series a first test, and I think a bit more work is needed :-) > > [ 1.455533] adv748x 0-0070: Endpoint /soc/i2c@e6500000/video-receiver@70/ > port@7/endpoint on port 7 > [ 1.464683] adv748x 0-0070: Endpoint /soc/i2c@e6500000/video-receiver@70/ > port@8/endpoint on port 8 > [ 1.473728] adv748x 0-0070: Endpoint /soc/i2c@e6500000/video-receiver@70/ > port@a/endpoint on port 10 > [ 1.484835] adv748x 0-0070: chip found @ 0xe0 revision 2143 > [ 1.639470] adv748x 0-0070: No endpoint found for txb > [ 1.644653] adv748x 0-0070: Failed to probe TXB I fear this is a design choice in the adv748x driver. Currently the driver requires both of its two CSI-2 transmitters to be connected/used else probe fails. Furthermore the HDMI capture is always routed to TXA while the analog capture is always routed to TXB. Now that we have a board where only TXA is connected but both HDMI and analog captures are used maybe it's time to do some more work on v4l2 and the adv748x driver ;-P What's missing: - Probe should be OK with either TXA or TXB connected and not bail if not both are used. - The media_device_ops or at least the .link_notify() callback of that struct must be changed so not one driver in the media graph is responsible for all links. In this case rcar-vin provides the callback and rcar-vin should not judge which links between the adv748x subdevices are OK to enable/disable. Currently the links between the adv748x subdevices are immutably enabled to avoid this particular problem. > > > PS: the list of upported patches will be sent separately. > > > > Jacopo Mondi (5): > > media: dt-bindings: media: rcar-vin: Add R8A77990 support > > media: rcar-vin: Add support for R-Car R8A77990 > > dt-bindings: media: rcar-csi2: Add R8A77990 > > media: rcar-csi2: Add R8A77990 support > > arm64: dts: renesas: ebisu: Add HDMI and CVBS input > > > > Koji Matsuoka (1): > > arm64: dts: r8a77990: Add VIN and CSI-2 device nodes > > > > Takeshi Kihara (2): > > pinctrl: sh-pfc: r8a77990: Add VIN pins, groups and functions > > arm64: dts: r8a77990: Add I2C device nodes > > > > .../devicetree/bindings/media/rcar_vin.txt | 1 + > > .../bindings/media/renesas,rcar-csi2.txt | 1 + > > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 86 ++++ > > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 202 +++++++++ > > drivers/media/platform/rcar-vin/rcar-core.c | 20 + > > drivers/media/platform/rcar-vin/rcar-csi2.c | 9 + > > drivers/pinctrl/sh-pfc/pfc-r8a77990.c | 504 ++++++++++++++++++ > > 7 files changed, 823 insertions(+) > > -- > Regards, > > Laurent Pinchart > > > -- Regards, Niklas Söderlund
