Hello!
On 08/13/2018 06:19 PM, Laurent Pinchart wrote:
>> Define the Condor/V3HSK board dependent parts of the DU and LVDS device
>> nodes. Also add the device nodes for Thine THC63LVD1024 LVDS decoder and
>> Analog Devices ADV7511W HDMI transmitter...
>>
>> Based on the original (and large) patch by Vladimir Barinov.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
>>
>> ---
>> Changes in version 2:
>> - added the V3HSK DT update, reworded the description, renamed the patch;
>> - added a space between the HDMI node name and a brace.
>>
>> arch/arm64/boot/dts/renesas/r8a77980-condor.dts | 106 ++++++++++++++++++++
>> arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts | 120 ++++++++++++++++++++
>> 2 files changed, 226 insertions(+)
>
> I would have split that in two patchees.
>
>>
>> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
>> ===================================================================
>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
[...]
>> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts
>> ===================================================================
>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts
>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts
>> @@ -27,6 +27,63 @@
>> /* first 128MB is reserved for secure area. */
>> reg = <0 0x48000000 0 0x78000000>;
>> };
>> +
>> + hdmi-out {
>> + compatible = "hdmi-connector";
>> + type = "a";
>> +
>> + port {
>> + hdmi_con: endpoint {
>> + remote-endpoint = <&adv7511_out>;
>> + };
>> + };
>> + };
>> +
>> + lvds-decoder {
>> + compatible = "thine,thc63lvd1024";
>> + vcc-supply = <&vcc3v3_d5>;
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> + thc63lvd1024_in: endpoint {
>> + remote-endpoint = <&lvds0_out>;
>> + };
>> + };
>> +
>> + port@2 {
>> + reg = <2>;
>> + thc63lvd1024_out: endpoint {
>> + remote-endpoint = <&adv7511_in>;
>> + };
>> + };
>> + };
>> + };
>> +
>> + vcc1v8_d4: regulator-0 {
>> + compatible = "regulator-fixed";
>> + regulator-name = "VCC1V8_D4";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <1800000>;
>> + regulator-boot-on;
>> + regulator-always-on;
>> + };
>> +
>> + vcc3v3_d5: regulator-1 {
>> + compatible = "regulator-fixed";
>> + regulator-name = "VCC3V3_D5";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-boot-on;
>> + regulator-always-on;
>> + };
>> +};
>> +
>> +&du {
>> + status = "okay";
>
> No dot clock for the DU ?
You're right, there's OSC1 providing 148.5 MHz. Fixed.
> Apart from that,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Thanks.
MBR, Sergei
