On 08/20/2018 05:59 PM, Magnus Damm wrote: > From: Magnus Damm <damm+renesas@xxxxxxxxxxxxx> > > Since only full-duplex operation is supported by the > hardware, remove duplex handling code and keep the > register setting of ECMR.DM fixed at 1. > > This updates the driver implementation to follow the > data sheet text "This bit should always be set to 1." > > Not-Yet-Signed-off-by: Magnus Damm <damm+renesas@xxxxxxxxxxxxx> > Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper") Fixes: tag should precede sign-off. [...] You missed to add this from the previous review: Reviewed-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> The net.git repo is always open, so you can post these patches to netdev already... MBR, Sergei