Hi Chris, Thanks for the feedback. > Subject: RE: [PATCH 2/2] pinctrl: sh-pfc: r8a7796: Add R8A774A1 PFC support > > Hello Biju, > > > From: Biju Das <biju.das@xxxxxxxxxxxxxx> > > Sent: 13 August 2018 14:53 > > > > Renesas RZ/G2M (r8a774a1) is pin compatible with R-Car M3-W (r8a7796), > > however it doesn't have several automotive specific peripherals. Add a > > r8a7796 specific pin groups/functions along with common pin > > groups/functions for supporting both r8a7796 and r8a7794a1 SoC. > s|r8a7794a1|r8a774a1 Will fix this and send v2. Regards, Biju > > > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > > Reviewed-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> > > --- > > drivers/pinctrl/sh-pfc/Kconfig | 5 + > > drivers/pinctrl/sh-pfc/Makefile | 1 + > > drivers/pinctrl/sh-pfc/core.c | 6 + > > drivers/pinctrl/sh-pfc/pfc-r8a7796.c | 837 > > ++++++++++++++++++------------- > > ---- > > drivers/pinctrl/sh-pfc/sh_pfc.h | 1 + > > 5 files changed, 453 insertions(+), 397 deletions(-) > > > > diff --git a/drivers/pinctrl/sh-pfc/Kconfig > > b/drivers/pinctrl/sh-pfc/Kconfig index 43d950c1..6a7254c 100644 > > --- a/drivers/pinctrl/sh-pfc/Kconfig > > +++ b/drivers/pinctrl/sh-pfc/Kconfig > > @@ -49,6 +49,11 @@ config PINCTRL_PFC_R8A77470 > > depends on ARCH_R8A77470 > > select PINCTRL_SH_PFC > > > > +config PINCTRL_PFC_R8A774A1 > > + def_bool y > > + depends on ARCH_R8A774A1 > > + select PINCTRL_SH_PFC > > + > > config PINCTRL_PFC_R8A7778 > > def_bool y > > depends on ARCH_R8A7778 > > diff --git a/drivers/pinctrl/sh-pfc/Makefile > > b/drivers/pinctrl/sh-pfc/Makefile index d0b29c5..9510a48 100644 > > --- a/drivers/pinctrl/sh-pfc/Makefile > > +++ b/drivers/pinctrl/sh-pfc/Makefile > > @@ -7,6 +7,7 @@ obj-$(CONFIG_PINCTRL_PFC_R8A7740)+= pfc- > > r8a7740.o > > obj-$(CONFIG_PINCTRL_PFC_R8A7743)+= pfc-r8a7791.o > > obj-$(CONFIG_PINCTRL_PFC_R8A7745)+= pfc-r8a7794.o > > obj-$(CONFIG_PINCTRL_PFC_R8A77470)+= pfc-r8a77470.o > > +obj-$(CONFIG_PINCTRL_PFC_R8A774A1)+= pfc-r8a7796.o > > obj-$(CONFIG_PINCTRL_PFC_R8A7778)+= pfc-r8a7778.o > > obj-$(CONFIG_PINCTRL_PFC_R8A7779)+= pfc-r8a7779.o > > obj-$(CONFIG_PINCTRL_PFC_R8A7790)+= pfc-r8a7790.o > > diff --git a/drivers/pinctrl/sh-pfc/core.c > > b/drivers/pinctrl/sh-pfc/core.c index > > c671c3c..0122471 100644 > > --- a/drivers/pinctrl/sh-pfc/core.c > > +++ b/drivers/pinctrl/sh-pfc/core.c > > @@ -509,6 +509,12 @@ static const struct of_device_id sh_pfc_of_table[] Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.