Hello Biju,
> -----Original Message-----
> From: Biju Das
> Sent: 13 August 2018 11:26
> To: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>;
> Catalin Marinas <catalin.marinas@xxxxxxx>; Will Deacon <will.deacon@xxxxxxx>
> Cc: Simon Horman <horms@xxxxxxxxxxxx>; Magnus Damm <magnus.damm@xxxxxxxxx>; linux-renesas-soc@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Geert Uytterhoeven <geert+renesas@xxxxxxxxx>; Chris Paterson
> <Chris.Paterson2@xxxxxxxxxxx>
> Subject: RE: [PATCH] arm64: dts: renesas: Initial r8a774a1 SoC device tree
>
> Hello Fabrizio,
>
> > Hello Biju,
> >
> > Thank you for your patch.
> >
> > > -----Original Message-----
> > > From: Biju Das <biju.das@xxxxxxxxxxxxxx>
> > > Sent: 13 August 2018 08:42
> > > To: Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland
> > > <mark.rutland@xxxxxxx>; Catalin Marinas <catalin.marinas@xxxxxxx>;
> > > Will Deacon <will.deacon@xxxxxxx>
> > > Cc: Biju Das <biju.das@xxxxxxxxxxxxxx>; Simon Horman
> > > <horms@xxxxxxxxxxxx>; Magnus Damm <magnus.damm@xxxxxxxxx>;
> > > linux-renesas-soc@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Geert Uytterhoeven
> > > <geert+renesas@xxxxxxxxx>; Chris Paterson
> > > <Chris.Paterson2@xxxxxxxxxxx>; Fabrizio Castro
> > > <fabrizio.castro@xxxxxxxxxxxxxx>
> > > Subject: [PATCH] arm64: dts: renesas: Initial r8a774a1 SoC device tree
> > >
> > > Basic support for the RZ/G2M SoC.
> > >
> > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> > > ---
> > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 192
> > > ++++++++++++++++++++++++++++++
> > > 1 file changed, 192 insertions(+)
> > > create mode 100644 arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > >
> > > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > > b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > > new file mode 100644
> > > index 0000000..f3641c0
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > > @@ -0,0 +1,192 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * Device Tree Source for the r8a774a1 SoC
> > > + *
> > > + * Copyright (C) 2018 Renesas Electronics Corp.
> > > + */
> > > +
> > > +#include <dt-bindings/interrupt-controller/irq.h>
> > > +#include <dt-bindings/interrupt-controller/arm-gic.h>
> > > +#include <dt-bindings/clock/renesas-cpg-mssr.h>
> > > +
> > > +#define CPG_AUDIO_CLK_I10
> >
> > I believe there is no use case for this macro, therefore I think this device tree
> > can live without it.
> > With that fixed:
>
> This clock is SoC specific clock similar to R-Car Gen-3 H3/M3/M3N. Also the same clock is mentioned in Table 8.2b List of clocks of
> RZ/G2M hardware manual. So I think it is ok.
>
> If you think defining SoC specific clock is wrong in this file , we need to fix other boards as well.
I believe that macro is used on other platforms to provide a little bit of abstraction when defining the clocks of rcar_sound, therefore it's ok for the other boards.
We could provide the same thing here, it's not going to hurt anybody, but at the moment there is no reference design for this new SoC therefore there is no use case for this, so maybe we could wait until we have a use case for this?
Cheers,
Fab
>
>
> > > +
> > > +/ {
> > > +compatible = "renesas,r8a774a1";
> > > +#address-cells = <2>;
> > > +#size-cells = <2>;
> > > +
> > > +/*
> > > + * The external audio clocks are configured as 0 Hz fixed frequency
> > > + * clocks by default.
> > > + * Boards that provide audio clocks should override them.
> > > + */
> > > +audio_clk_a: audio_clk_a {
> > > +compatible = "fixed-clock";
> > > +#clock-cells = <0>;
> > > +clock-frequency = <0>;
> > > +};
> > > +
> > > +audio_clk_b: audio_clk_b {
> > > +compatible = "fixed-clock";
> > > +#clock-cells = <0>;
> > > +clock-frequency = <0>;
> > > +};
> > > +
> > > +audio_clk_c: audio_clk_c {
> > > +compatible = "fixed-clock";
> > > +#clock-cells = <0>;
> > > +clock-frequency = <0>;
> > > +};
> > > +
> > > +/* External CAN clock - to be overridden by boards that provide it */
> > > +can_clk: can {
> > > +compatible = "fixed-clock";
> > > +#clock-cells = <0>;
> > > +clock-frequency = <0>;
> > > +};
> > > +
> > > +cpus {
> > > +#address-cells = <1>;
> > > +#size-cells = <0>;
> > > +
> > > +a57_0: cpu@0 {
> > > +compatible = "arm,cortex-a57", "arm,armv8";
> > > +reg = <0x0>;
> > > +device_type = "cpu";
> > > +power-domains = <&sysc 0>;
> > > +next-level-cache = <&L2_CA57>;
> > > +enable-method = "psci";
> > > +clocks =<&cpg CPG_CORE 0>;
> > > +};
> > > +
> > > +a57_1: cpu@1 {
> > > +compatible = "arm,cortex-a57", "arm,armv8";
> > > +reg = <0x1>;
> > > +device_type = "cpu";
> > > +power-domains = <&sysc 1>;
> > > +next-level-cache = <&L2_CA57>;
> > > +enable-method = "psci";
> > > +clocks =<&cpg CPG_CORE 0>;
> > > +};
> > > +
> > > +L2_CA57: cache-controller-0 {
> > > +compatible = "cache";
> > > +power-domains = <&sysc 12>;
> > > +cache-unified;
> > > +cache-level = <2>;
> > > +};
> > > +};
> > > +
> > > +extal_clk: extal {
> > > +compatible = "fixed-clock";
> > > +#clock-cells = <0>;
> > > +/* This value must be overridden by the board */
> > > +clock-frequency = <0>;
> > > +};
> > > +
> > > +extalr_clk: extalr {
> > > +compatible = "fixed-clock";
> > > +#clock-cells = <0>;
> > > +/* This value must be overridden by the board */
> > > +clock-frequency = <0>;
> > > +};
> > > +
> > > +/* External PCIe clock - can be overridden by the board */
> > > +pcie_bus_clk: pcie_bus {
> > > +compatible = "fixed-clock";
> > > +#clock-cells = <0>;
> > > +clock-frequency = <0>;
> > > +};
> > > +
> > > +pmu_a57 {
> > > +compatible = "arm,cortex-a57-pmu";
> > > +interrupts-extended = <&gic GIC_SPI 72
> > IRQ_TYPE_LEVEL_HIGH>,
> > > + <&gic GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
> > > +interrupt-affinity = <&a57_0>, <&a57_1>;
> > > +};
> > > +
> > > +psci {
> > > +compatible = "arm,psci-1.0", "arm,psci-0.2";
> > > +method = "smc";
> > > +};
> > > +
> > > +/* External SCIF clock - to be overridden by boards that provide it */
> > > +scif_clk: scif {
> > > +compatible = "fixed-clock";
> > > +#clock-cells = <0>;
> > > +clock-frequency = <0>;
> > > +};
> > > +
> > > +soc {
> > > +compatible = "simple-bus";
> > > +interrupt-parent = <&gic>;
> > > +#address-cells = <2>;
> > > +#size-cells = <2>;
> > > +ranges;
> > > +
> > > +cpg: clock-controller@e6150000 {
> > > +compatible = "renesas,r8a774a1-cpg-mssr";
> > > +reg = <0 0xe6150000 0 0x0bb0>;
> > > +clocks = <&extal_clk>, <&extalr_clk>;
> > > +clock-names = "extal", "extalr";
> > > +#clock-cells = <2>;
> > > +#power-domain-cells = <0>;
> > > +#reset-cells = <1>;
> > > +};
> > > +
> > > +rst: reset-controller@e6160000 {
> > > +compatible = "renesas,r8a774a1-rst";
> > > +reg = <0 0xe6160000 0 0x018c>;
> > > +};
> > > +
> > > +sysc: system-controller@e6180000 {
> > > +compatible = "renesas,r8a774a1-sysc";
> > > +reg = <0 0xe6180000 0 0x0400>;
> > > +#power-domain-cells = <1>;
> > > +};
> > > +
> > > +gic: interrupt-controller@f1010000 {
> > > +compatible = "arm,gic-400";
> > > +#interrupt-cells = <3>;
> > > +#address-cells = <0>;
> > > +interrupt-controller;
> > > +reg = <0x0 0xf1010000 0 0x1000>,
> > > + <0x0 0xf1020000 0 0x20000>,
> > > + <0x0 0xf1040000 0 0x20000>,
> > > + <0x0 0xf1060000 0 0x20000>;
> > > +interrupts = <GIC_PPI 9
> > > +(GIC_CPU_MASK_SIMPLE(2) |
> > IRQ_TYPE_LEVEL_HIGH)>;
> > > +clocks = <&cpg CPG_MOD 408>;
> > > +clock-names = "clk";
> > > +power-domains = <&sysc 32>;
> > > +resets = <&cpg 408>;
> > > +};
> > > +
> > > +prr: chipid@fff00044 {
> > > +compatible = "renesas,prr";
> > > +reg = <0 0xfff00044 0 4>;
> > > +};
> > > +};
> > > +
> > > +timer {
> > > +compatible = "arm,armv8-timer";
> > > +interrupts-extended = <&gic GIC_PPI 13
> > (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
> > > + <&gic GIC_PPI 14
> > (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
> > > + <&gic GIC_PPI 11
> > (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
> > > + <&gic GIC_PPI 10
> > (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>;
> > > +};
> > > +
> > > +/* External USB clocks - can be overridden by the board */
> > > +usb3s0_clk: usb3s0 {
> > > +compatible = "fixed-clock";
> > > +#clock-cells = <0>;
> > > +clock-frequency = <0>;
> > > +};
> > > +
> > > +usb_extal_clk: usb_extal {
> > > +compatible = "fixed-clock";
> > > +#clock-cells = <0>;
> > > +clock-frequency = <0>;
> > > +};
> > > +};
> > > --
> > > 2.7.4
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
