Hello Engeniu, On Fri, Aug 10, 2018 at 03:48:44PM +0200, Eugeniu Rosca wrote: > Hi again Jacopo, > > On Mon, Aug 06, 2018 at 12:40:02AM +0200, Eugeniu Rosca wrote: > > Hi Jacopo, > > > > Thanks for your comments. Please, find my replies below. > > > > On Sun, Aug 05, 2018 at 10:15:43AM +0200, jacopo mondi wrote: > > > Helle Eugeniu, > > > > > > On Sun, Aug 05, 2018 at 01:11:09AM +0200, Eugeniu Rosca wrote: > > > > In harmony with ATF and U-Boot outputs [1] and [2], the new board is > > > > based on M3-N revision ES1.1 and the amount of memory present on SiP > > > > is 2GiB, contiguously addressed. > > > > > > Not sure why the amount of installed system memory is relevant for > > > this commit.. > > > > To be honest, I don't know precisely what's encoded in the board string > > (particularly the one documented in this commit RTP0RC77965SKBX010SA00). > > > > The only thing unmistakenly present there is the SoC model 77965 (i.e. > > M3-N), but I am quite clueless about the rest. > > > > What I can say for sure is that the end-user experience of a R-Car Gen3 > > reference board clearly depends on below parameters: > > - [A] SoC (model, revision) including SRAM and on-chip peripherals > > - [B] DRAM (amount, linear/2ch/4ch split) > > - [C] Hyperflash (amount) > > - [D] board's PCB (revision) > > - [E] board's off-chip peripherals (model, revision) > > > > I don't know how many of these parameters are embedded in the board > > string, but since you are suggesting that RAM amount is not (IOW > > Renesas will potentially release several RTP0RC77965SKBX010SA00 > > boards with different amounts of memory), I will happily update > > the commit description. > > Since I found two H3-ES2.0 Starter Kit samples with different amount of > RAM (4 vs 8 GiB) each having a unique board id [1], I take this as > evidence that Renesas encodes the amount of RAM in the board id. > Therefore, I will not change the description of this patch in v2, > unless you comment/NAK. Thank you. > Thanks for digging into this, feel free to ignore my comment. > [1] https://patchwork.kernel.org/patch/10555957/#22169325 > > Best regards, > Eugeniu.
Attachment:
signature.asc
Description: PGP signature
