On Mon, Aug 6, 2018 at 1:13 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > On Mon, Aug 6, 2018 at 12:38 PM Laurent Pinchart > <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > > On Sunday, 5 August 2018 02:11:02 EEST Eugeniu Rosca wrote: > > > In the context of M3N-ULCB (RTP0RC77965SKBX010SA00) board bring-up, it's > > > rather pointless to add a new "renesas,m3nulcb" compatible string. Any > > > SoC-level differences between the two variants of ULCB (M3 and M3-N) > > > should be successfully covered by making use of existing > > > "renesas,r8a7796" and "renesas,r8a77965" compatibles. > > > > > > Prior to adding M3-N Starter Kit to the list, rename: > > > - "renesas,h3ulcb" => "renesas,ulcb" > > > - "renesas,m3ulcb" => "renesas,ulcb" > > > > This bothers me more than the naming convention in patch 01/14, as this change > > would completely hide differences between the H3 and M3-N versions of the > > ULCB. Compatible strings are listed in a decreasing order of specificity, and > > having "renesas,ulcb" as the most-specific compatible string means that the > > two boards are supposed to be identical, while they are not. > > AFAIK the boards are identical (cfr. ), except for the SiP mounted. > Cfr. e.g. the combined R-Car_StarterKit_Gen3_H3_M3_DEV_Rev.053.pdf > ("Renesas R-Car H3/M3 Device Manual", incl. schematics). Sorry, the schematics are in a separate file R-Car_StarterKit_Gen3_SCH_Rev.110.pdf with title "R-Car_Gen3 Starterkit", for both the Pro and Premier versions. But "ULCB" is an unofficial name. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds