Hi Eugeniu On 05/08/18 00:11, Eugeniu Rosca wrote: > After adding CAN support to arch/arm64/boot/dts/renesas/r8a77965.dtsi, > checkpatch complained that the new compatible string > "renesas,can-r8a77965" is not documented. Fix the warning. > Thanks to the correct ordering of your patches, (you have this one *before* adding the CAN support to r8a77965) This commit message seems to be predicting the future somewhat. Perhaps just a simpler commit message would suffice: "Document the support for rcar_can on R8A77965 SoC devices." > Signed-off-by: Eugeniu Rosca <erosca@xxxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/net/can/rcar_can.txt | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicetree/bindings/net/can/rcar_can.txt > index 94a7f33ac5e9..23264451a5a4 100644 > --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt > +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt > @@ -13,6 +13,7 @@ Required properties: > "renesas,can-r8a7794" if CAN controller is a part of R8A7794 SoC. > "renesas,can-r8a7795" if CAN controller is a part of R8A7795 SoC. > "renesas,can-r8a7796" if CAN controller is a part of R8A7796 SoC. > + "renesas,can-r8a77965" if CAN controller is a part of R8A77965 SoC. > "renesas,rcar-gen1-can" for a generic R-Car Gen1 compatible device. > "renesas,rcar-gen2-can" for a generic R-Car Gen2 or RZ/G1 > compatible device. > @@ -28,9 +29,8 @@ Required properties: > - pinctrl-0: pin control group to be used for this controller. > - pinctrl-names: must be "default". > > -Required properties for "renesas,can-r8a7795" and "renesas,can-r8a7796" > -compatible: > -In R8A7795 and R8A7796 SoCs, "clkp2" can be CANFD clock. This is a div6 clock > +Required properties for compatibles [A], [B] and [C]: > +For the denoted SoCs, "clkp2" can be CANFD clock. This is a div6 clock This paragraph could be rewrapped... > and can be used by both CAN and CAN FD controller at the same time. It needs to > be scaled to maximum frequency if any of these controllers use it. This is done > using the below properties: > @@ -38,6 +38,10 @@ using the below properties: > - assigned-clocks: phandle of clkp2(CANFD) clock. > - assigned-clock-rates: maximum frequency of this clock. > > +[A] "renesas,can-r8a7795" > +[B] "renesas,can-r8a7796" > +[C] "renesas,can-r8a77965" > +> Optional properties: > - renesas,can-clock-select: R-Car CAN Clock Source Select. Valid values are: > <0x0> (default) : Peripheral clock (clkp1) >
