Hi Simon, On Thu, Aug 2, 2018 at 1:13 PM Simon Horman <horms@xxxxxxxxxxxx> wrote: > On Mon, Jul 30, 2018 at 09:33:38AM +0200, Wolfram Sang wrote: > > From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > This patch adds SATA controller node for the R8A77965 SoC. > > > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > [wsa: rebased to upstream base] > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > --- > > > > Changes since v1: > > * sorted it according to address (Thanks, Geert!) > > * added Geert's tag > > > > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > index 0cd44461a0bd..bf22efb82cbf 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > @@ -1507,6 +1507,17 @@ > > status = "disabled"; > > }; > > > > + sata: sata@ee300000 { > > + compatible = "renesas,sata-r8a77965", > > + "renesas,rcar-gen3-sata"; > > + reg = <0 0xee300000 0 0x200000>; > > + interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&cpg CPG_MOD 815>; > > + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>; > > + resets = <&cpg 815>; > > + status = "disabled"; > > Is it intentional that there is no iommus property here? Because none of the other device nodes have iommus properties yet? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds