Hi Laurent,
On Wed, Jul 11, 2018 at 11:16 PM Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> On Thursday, 5 July 2018 13:55:00 EEST Geert Uytterhoeven wrote:
> > On Thu, Jun 14, 2018 at 1:36 PM Simon Horman <horms@xxxxxxxxxxxx> wrote:
> > > This series is comprised of backports to v4.14 of the following
> > > components from their standard as of v4.16 to that of v4.17:
>
> [snip]
>
> > I subjected it to the same testing I do for each renesas-drivers release.
> >
> > Regressions from v4.14.48:
>
> [snip]
>
> > - Koelsch, Salvator-X (R-Car M3-W), Salvator-XS (R-Car H3 ES2.0):
> >
> > +rcar-du feb00000.display: no connector for encoder
> > /soc/lvds@feb90000, skipping
> >
> > Laurent: do you know what's missing?
>
> That message is printed when no connector node is linked in DT through OF
> graph to the encoder DT node output port. That's expected in this case as we
> have an LVDS encoder, but not connected panel. However,
> rcar_du_encoders_init_one() should return before printing that message due to
>
> if (!of_device_is_available(entity)) {
> dev_dbg(rcdu->dev,
> "connected entity %pOF is disabled, skipping\n",
> entity);
> return -ENODEV;
> }
>
> as the LVDS encoder nodes in DT should be disabled.
The LVDS encoder nodes were enabled in the following commits:
- e5c3f4707f3956a2 ("ARM: dts: r8a7791: Convert to new LVDS DT bindings"),
for Koelsch and Porter, but none of them has a connected panel?
- 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT bindings"),
for both LVDS instances on Lager, but the second one doesn't have a panel
connected?
edb0c3affe5214a2 ("ARM: dts: r8a7793: Convert to new LVDS DT bindings")
for Gose did it right, though.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
