On 06/13/2018 01:21 PM, Geert Uytterhoeven wrote: > Hi Simon, Hi, > On Wed, Jun 13, 2018 at 1:06 PM Simon Horman <horms@xxxxxxxxxxxx> wrote: >> On Mon, Jun 11, 2018 at 02:15:13PM +0200, Marek Vasut wrote: >>> Rather than hard-coding the quirk topology, which stopped scaling, >>> parse the information from DT. The code looks for all compatible >>> PMICs -- da9063 and da9210 -- and checks if their IRQ line is tied >>> to the same pin. If so, the code sends a matching sequence to the >>> PMIC to deassert the IRQ. >>> >>> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> >>> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> >>> Cc: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> >>> Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx> >>> Cc: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> >>> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx >>> Acked-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> >>> Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> (on Koelsch) >> >> This looks fine to me but I will wait to see if there are other reviews >> before applying. >> >> Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> > > Note that applying it now will break gose, as its DTS doesn't describe all > regulators yet. https://patchwork.kernel.org/patch/10548919/ should fix this. https://patchwork.kernel.org/patch/10548923/ for Silk. -- Best regards, Marek Vasut