Hi Laurent, Mauro > > > > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > > > > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > > > --- > > > > > > > > drivers/media/platform/soc_camera/soc_camera_platform.c | 5 +---- > > > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > > > I have second thoughts about this one. Is it worth switching to SPDX as > > > we're in the process of removing soc-camera from the kernel ? If it is, > > > shouldn't you also address the other soc-camera source files ? I would > > > personally prefer not touching soc-camera as it won't be there for much > > > longer. > > > > I'd say that, if there are code there that will be converted and will stay > > at the Kernel, the SPDX patchset is a good thing, as it makes easier for > > the conversion, as it would mean one less thing to be concerned with. > > > > So, I'm inclined to apply this patch series. > > My comment referred to this patch only, not the whole series. The rest of the > series is totally fine, only soc_camera_platform.c doesn't seem worth touching > to me as it's going away. As far as I know the only remaining user is > sh_mobile_ceu_camera.c, which isn't used by any platform anymore. It's just a > matter of dropping it (I think Jacopo has submitted a patch already), and then > removing the drivers/media/platform/soc_camera/ directory. > > I've taken the whole series in my tree and collected acks, so I'll submit a > pull request when we will decide what to do with patch 01/11. I have no special opinion about it. If you think it is not needed, please drop it. soc_camera_platform is my (and Magnus's) driver of memories, almost 10 years ago. It is a littile bit lonely that it will disappear, ut there is no problem. Thanks soc_camera_platform Best regards --- Kuninori Morimoto
