Hi Yamada-san,
On Thu, Jul 26, 2018 at 11:15 AM Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
> 2018-07-26 17:25 GMT+09:00 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>:
> > On Thu, Jul 26, 2018 at 5:33 AM Masahiro Yamada
> > <yamada.masahiro@xxxxxxxxxxxxx> wrote:
> >> This commit renames files as follows:
> >>
> >> tmio_mmc_core.c -> tmio_mmc.c
> >> tmio_mmc.c -> tmio_mmc_original.c
> >> renesas_sdhi_core.c -> tmio_mmc_sdhi.c
> >> renesas_sdhi.h -> tmio_mmc_sdhi.h
> >> renesas_sdhi_internal_dmac.c -> tmio_mmc_sdhi_internal_dmac.c
> >> renesas_sdhi_sys_dmac.c -> tmio_mmc_sdhi_sys_dmac.c
> >
> > I have mixed feelings about the last two renames, especially about the last
> > one: SYS-DMAC is very Renesas-specific, as it's a separate IP block in
> > Renesas SoCs.
> > 2. Are there other SoCs using an external DMAC?
>
> Yes. Some old SoCs in UniPhier SoC family rely on
> the external DMAC, like renesas_sdhi_sys_dmac.c
>
> > Is the interface to the external DMAC similar?
> > If yes, perhaps it should be renamed to tmio_mmc_sdhi_external_dmac.c?
>
> "sdhi" is already Renesas-specific name, isn't it?
Right, I'm mixing up SDHI and SDHC.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
