On Wed, Jul 18, 2018 at 04:47:56AM +0900, Yoshihiro Kaneko wrote: > This series adds sound support for r8a77965 (R-Car M3-N). > This series is based on the devel branch of Simon Horman's renesas tree. > > Hiroyuki Yokoyama (1): > ASoC: rsnd: Document R-Car M3-N support > > Takeshi Kihara (6): > arm64: dts: renesas: r8a77965: Add Audio-DMAC device nodes > arm64: dts: renesas: r8a77965: Add Sound device node and SSI support > arm64: dts: renesas: r8a77965: Add Sound SRC support > arm64: dts: renesas: r8a77965: Add Sound DVC device nodes > arm64: dts: renesas: r8a77965: Add Sound CTU support > arm64: dts: renesas: r8a77965: Add Sound MIX support > > .../devicetree/bindings/sound/renesas,rsnd.txt | 1 + > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 245 ++++++++++++++++++++- Thanks Kaneko-san, in general this series looks good, however, I would like to ask you to squash all the dts patches (the patches by Kihara-san) into a single patch. For many years now we have split patches up as this series does. And no doubt that is why BPS team chose to split up the patches that you have based this patchset on. However, we were recently asked by the Olof Johansson to squash patches together to make the high-level intent of patches clearer to him in his position of ARM-SoC co-maintainer. So while what you have done is correct, it is now the "old way". Please squash the patches together as this is the "new way". Thanks!
