On 07/19/2018 08:30 PM, Magnus Damm wrote: >>> From: Magnus Damm <damm+renesas@xxxxxxxxxxxxx> >>> >>> Since only full-duplex operation is supported by the >>> hardware, remove duplex handling code and keep the >>> register setting of ECMR.DM fixed at 1. >>> >>> This updates the driver implementation to follow the >>> data sheet text "This bit should always be set to 1." >>> >>> Not-Yet-Signed-off-by: Magnus Damm <damm+renesas@xxxxxxxxxxxxx> >> >> Sounds like a fix, please provide a Fixes: tag (I think we're fixing >> the initial driver commit here). > > Yeah it is a fix if you consider not following the data sheet a bug. Trying to support a non-working feature seems to be a bug... > The same applies to the first patch but it fixes the issue that we > don't setup the PHY correctly. Yes. >> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > > Thanks! My duty as the official reviewer. :-) [...] MBR, Sergei
