> I'm sure one could dereference the host->taps variable and do the bit
> operations but that feels like a bad idea. The other option is to use
> bitmap_{from,to}_arr32() to access the bitmap as 32 bit integers but
> that too feels odd and more complex then using the bitmap helper
> functions.
I see. I think we need to refactor the tap related code anyhow when we
support the 8 tap SoCs. Because then all the 'tap * 2' is wrong. Then we
can also see if we really want a bitmap or just use a ulong? So, your
solution will do for now.
> I will await your feedback before on this before I post the next version
> of this series.
One minor idea I had, but this may be bike-shedding:
int offset = (i + host->num_taps) % (2 * host->num_taps)?
Dunno, your call.
Attachment:
signature.asc
Description: PGP signature
