Hi Kaneko-san, On Tue, Jul 17, 2018 at 9:48 PM Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> wrote: > From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > This patch adds Audio-DMAC{0,1} device nodes for the R8A77965 SoC. > > Based on a similar patch of the R8A7796 device tree > by uninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>. > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > @@ -1386,6 +1386,74 @@ > status = "disabled"; > }; > > + audma0: dma-controller@ec700000 { > + }; > + Please respect sort order (by unit address, per device group). The two audma nodes should be inserted just before usb@ee000000. > ohci0: usb@ee080000 { > compatible = "generic-ohci"; > reg = <0 0xee080000 0 0x100>; With the above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds