Hi Niklas, Thanks for your backport! On Tue, Jul 17, 2018 at 5:24 PM Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote: commit 550b6f7e8cf93fc2753aa01e655ed5471012ab5a upstream. > The datasheet does not document any registers to control drive strength, > and no drive strength registers are for this reason described for this > SoC. The flags indicating that drive strength can be controlled are > however set for some pins in the driver. > > This leads to a NULL pointer dereference when the sh-pfc core tries to > access the struct describing the drive strength registers, for example > when reading the sysfs file pinconf-pins. > > Fix this by removing the SH_PFC_PIN_CFG_DRIVE_STRENGTH from all pins > > Fixes: b92ac66a1819602b ("pinctrl: sh-pfc: Add R8A77970 PFC support") > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- > This is a backport of commit 550b6f7e8cf93fc2753aa01e655ed5471012ab5a > from Linusw linux-pinctrl.git tree. It's applicable for v4.16 and v4.17. Which is now upstream. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds