On 07/16/2018 10:52 PM, Sergei Shtylyov wrote: >> The wrong helper is used to swap the bytes when adding the lower bits of >> the TX descriptors tag field in the shared ds_tagl variable. The >> variable contains the DS[11:0] field and then the TAG[3:0] bits. >> >> The mistake was highlighted by the sparse warning: >> >> ravb_main.c:1622:31: left side has type restricted __le16 >> ravb_main.c:1622:31: right side has type unsigned short >> ravb_main.c:1622:31: warning: invalid assignment: |= >> ravb_main.c:1622:34: warning: cast to restricted __le16 > > Again, it's good that it's not a real bug! :-) Wait! It seems to be, according to your subject. I hope you understand that cpu_to_le16() and le16_to_cpu() do the same thing? >> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > [...] > > Acked-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> MBR, Sergei
