On Mon, Jul 16, 2018 at 2:20 PM Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote: > The wrong helper is used to swap the bytes when adding the lower bits of > the TX descriptors tag field in the shared ds_tagl variable. The > variable contains the DS[11:0] field and then the TAG[3:0] bits. > > The mistake was highlighted by the sparse warning: > > ravb_main.c:1622:31: left side has type restricted __le16 > ravb_main.c:1622:31: right side has type unsigned short > ravb_main.c:1622:31: warning: invalid assignment: |= > ravb_main.c:1622:34: warning: cast to restricted __le16 > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds