On Mon, Jul 02, 2018 at 10:09:41AM -0700, Olof Johansson wrote: > On Mon, Jun 25, 2018 at 7:03 AM, Simon Horman > <horms+renesas@xxxxxxxxxxxx> wrote: > > Hi Olof, Hi Kevin, Hi Arnd, > > > > Please consider these Renesas ARM64 based SoC DT updates for v4.19. > > > > > > The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40: > > > > Linux 4.18-rc1 (2018-06-17 08:04:49 +0900) > > > > are available in the git repository at: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-arm64-dt-for-v4.19 > > > > for you to fetch changes up to 6b284a81307848b4331453b02cf7a33c09719d4b: > > > > arm64: dts: renesas: r8a77995: Add MSIOF device nodes (2018-06-25 15:30:39 +0200) > > Thanks, merged into next/dt. > > I think you can still collapse some commits a bit further, for example > when a large number of devices are added to a new SoC, you don't need > a commit per device (i.e. the r8a77980 series). > > It's not a problem if it's just a few, but like last merge window when > it really added to a lot of small trivial patches it's adding noise to > someone looking at changelogs -- it's harder to get a feel for what > new things are going in on a larger scope. Keep in mind that you, as > maintainer, should feel free to squash together patches when you apply > them if it makes sense -- just make sure you retain authorship and > credits/COO. Thanks Olof, as I think you can see we have adjusted things somewhat in the light of the feedback you provided during the v4.18 development cycle. And we'll continue to do so. In the case of enabling various devices for the r8a77980 I do take your point with regards to squashing patches. Although I believe that in this case the patches came in over time, which makes them a little less obvious candidates for squashing than would be the case if they came in all at once. Nonetheless, I'll continue to work with the team to streamline our processes and make the pull requests as easy to digest as possible.
