Hi Morimoto-san, Thank you for the patch. On Wednesday, 4 July 2018 03:34:10 EEST Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > This patch is using C++ comment style for SPDX line only, > because driver author want it. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > I posted this because I don't know which style was OK. > Please pick-up best side patch > > v1 -> v2 > > - used // for SPDX line only > > drivers/dma/sh/rcar-dmac.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c > index 79d14af..ebd160d 100644 > --- a/drivers/dma/sh/rcar-dmac.c > +++ b/drivers/dma/sh/rcar-dmac.c > @@ -1,13 +1,10 @@ > +// SPDX-License-Identifier: GPL-2.0 > /* > * Renesas R-Car Gen2 DMA Controller Driver > * > * Copyright (C) 2014 Renesas Electronics Inc. > * > * Author: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > - * > - * This is free software; you can redistribute it and/or modify > - * it under the terms of version 2 of the GNU General Public License as > - * published by the Free Software Foundation. > */ > > #include <linux/delay.h> -- Regards, Laurent Pinchart