Hi Hans, On Wed, Jul 04, 2018 at 09:36:34AM +0200, Hans Verkuil wrote: > On 12/06/18 11:43, Jacopo Mondi wrote: > > Add R-Car R8A77995 SoC to the rcar-vin supported ones. > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> > > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Checkpatch reports: > > WARNING: DT compatible string "renesas,vin-r8a77995" appears un-documented -- check ./Documentation/devicetree/bindings/ > #29: FILE: drivers/media/platform/rcar-vin/rcar-core.c:1150: > + .compatible = "renesas,vin-r8a77995", > > I'll still accept this series since this compatible string is already used in > a dtsi, but if someone can document this for the bindings? A patch has been sent on May 21st for this https://patchwork.kernel.org/patch/10415587/ Bindings documentation usually gets in a release later than bindings users, to give time to bindings to be changed eventually before being documented. Simon, Geert, is this correct? Thanks j > > Regards, > > Hans > > > --- > > drivers/media/platform/rcar-vin/rcar-core.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c > > index a2d166f..bd99d56 100644 > > --- a/drivers/media/platform/rcar-vin/rcar-core.c > > +++ b/drivers/media/platform/rcar-vin/rcar-core.c > > @@ -1045,6 +1045,18 @@ static const struct rvin_info rcar_info_r8a77970 = { > > .routes = rcar_info_r8a77970_routes, > > }; > > > > +static const struct rvin_group_route rcar_info_r8a77995_routes[] = { > > + { /* Sentinel */ } > > +}; > > + > > +static const struct rvin_info rcar_info_r8a77995 = { > > + .model = RCAR_GEN3, > > + .use_mc = true, > > + .max_width = 4096, > > + .max_height = 4096, > > + .routes = rcar_info_r8a77995_routes, > > +}; > > + > > static const struct of_device_id rvin_of_id_table[] = { > > { > > .compatible = "renesas,vin-r8a7778", > > @@ -1086,6 +1098,10 @@ static const struct of_device_id rvin_of_id_table[] = { > > .compatible = "renesas,vin-r8a77970", > > .data = &rcar_info_r8a77970, > > }, > > + { > > + .compatible = "renesas,vin-r8a77995", > > + .data = &rcar_info_r8a77995, > > + }, > > { /* Sentinel */ }, > > }; > > MODULE_DEVICE_TABLE(of, rvin_of_id_table); > > >
Attachment:
signature.asc
Description: PGP signature
