Hi Sergei,
On Mon, Jun 25, 2018 at 10:37 PM Sergei Shtylyov
<sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
> The *enum* RPADIR_BIT was declared in the commit 86a74ff21a7a ("net:
> sh_eth: add support for Renesas SuperH Ethernet") adding SH771x support,
> however the SH771x manual doesn't have the RPADIR register described and,
> moreover, tells why the padding insertion must not be used. The newer SoC
> manuals do have RPADIR documented, though with somewhat different layout --
> update the *enum* according to these manuals...
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.h
> +++ net-next/drivers/net/ethernet/renesas/sh_eth.h
> @@ -403,8 +403,7 @@ enum DESC_I_BIT {
>
> /* RPADIR */
> enum RPADIR_BIT {
> - RPADIR_PADS1 = 0x20000, RPADIR_PADS0 = 0x10000,
> - RPADIR_PADR = 0x0003f,
> + RPADIR_PADS = 0x1f0000, RPADIR_PADR = 0xffff,
Perhaps add some comments?
RPADIR_PADS = 0x1f0000; /* Padding Size (insert N bytes of padding) */
RPADIR_PADR = 0xffff; /* Padding Slot (insert padding at byte N) */
> };
Note that none of the RPADIR enums are actually used.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
