On 06/07/2018 02:41 PM, Lee Jones wrote: > On Thu, 07 Jun 2018, Marek Vasut wrote: > >> On 06/06/2018 11:59 AM, Marek Vasut wrote: >>> Use devm_regmap_add_irq_chip() instead of plain regmap_add_irq_chip(), >>> which removes the need for da9063_irq_exit() altogether and also >>> fixes a bug in da9063_device_init() where the da9063_irq_exit() was >>> not called in a failpath. >>> >>> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> >>> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> >>> Cc: Lee Jones <lee.jones@xxxxxxxxxx> >>> Cc: Mark Brown <broonie@xxxxxxxxxx> >>> Cc: Steve Twiss <stwiss.opensource@xxxxxxxxxxx> >>> Cc: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> >>> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx >> >> So it's just this one patch that's missing AB/RB and the series should >> be good? > > Looks fine. Although we'll let it sit for a while in case anyone else > has any thoughts. Fine by me. > The merge window is currently open, so there is no rush to apply. This is still 4.18 material ? Hum, OK. >>> --- >>> V5: New patch >>> --- >>> drivers/mfd/da9063-core.c | 1 - >>> drivers/mfd/da9063-irq.c | 8 ++------ >>> include/linux/mfd/da9063/core.h | 1 - >>> 3 files changed, 2 insertions(+), 8 deletions(-) > > For my own reference: > Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx> Added to my tree. -- Best regards, Marek Vasut