Re: [PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 28, 2018 at 12:29:15PM +0200, Simon Horman wrote:
> On Mon, May 28, 2018 at 12:45:32PM +0300, Laurent Pinchart wrote:
> > Hi Simon,
> > 
> > On Monday, 28 May 2018 12:39:17 EEST Simon Horman wrote:
> > > On Fri, May 25, 2018 at 01:23:53PM +0300, Laurent Pinchart wrote:
> > > > On Friday, 25 May 2018 13:13:20 EEST Simon Horman wrote:
> > > >> On Thu, May 24, 2018 at 11:00:52AM +0300, Laurent Pinchart wrote:
> > > >>> On Wednesday, 21 February 2018 18:39:25 EEST Simon Horman wrote:
> > > >>>> On Wed, Feb 21, 2018 at 01:10:30AM +0200, Laurent Pinchart wrote:
> > > > 
> > > > [snip]
> > > > 
> > > >>>>> Laurent Pinchart (11):
> > > >>>>>   dt-bindings: display: renesas: Add R-Car LVDS encoder DT bindings
> > > >>>>>   dt-bindings: display: renesas: Deprecate LVDS support in the DU
> > > >>>>>     bindings
> > > >>>>>   drm: rcar-du: Fix legacy DT to create LVDS encoder nodes
> > > >>>>>   drm: rcar-du: Convert LVDS encoder code to bridge driver
> > > >>>>>   ARM: dts: r8a7790: Convert to new LVDS DT bindings
> > > >>>>>   ARM: dts: r8a7791: Convert to new LVDS DT bindings
> > > >>>>>   ARM: dts: r8a7792: Convert to new DU DT bindings
> > > >>>>>   ARM: dts: r8a7793: Convert to new LVDS DT bindings
> > > >>>>>   ARM: dts: r8a7794: Convert to new DU DT bindings
> > > >>>>>   arm64: dts: renesas: r8a7795: Convert to new LVDS DT bindings
> > > >>>>>   arm64: dts: renesas: r8a7796: Convert to new LVDS DT bindings
> > > >>>> 
> > > >>>> I have marked the dts patches above as deferred as they depend
> > > >>>> on the driver changes not to cause a regression. Please repost them
> > > >>>> or otherwise ping me once the driver dependencies are present in an
> > > >>>> rc release.
> > > >>> 
> > > >>> The driver changes have made it to v4.17-rc1. Is it too late for v4.18
> > > >>> ?
> > > >> 
> > > >> Unfortunately it is. Shall I apply them for v4.19?
> > > > 
> > > > Please do.
> > > 
> > > Hi Laurent,
> > > 
> > > I'm sorry to have to ask this, but in the light of Olof Johansson's recent
> > > comments in ("Re: [GIT PULL] Renesas ARM64 Based SoC DT Updates for v4.18")
> > > please consider squashing the DTS patches and reposting.
> > 
> > It's about time we stopped trying to game the kernel patch statistics :-)
> > 
> > Before I repost, has there been a consensus on the new rule ? And how are we 
> > expected to proceed from now on ?
> 
> No, there has not been. And I think there needs to be.

Here is my general advice:

When making changes to several files, if you feel that its the same change
made to those several files, then please consider one patch instead
of per-file patches.

What I am suggesting by the above is that we tweak our processes to
reduce the number of patches. If this goes poorly we can learn and go back
to the old patch per-file model. If it goes well we can consider further
patch consolidation.

I know that this is not a hard rule. But for now I'd like to leave people
with some discretion. Lets guide each other via the review process
as this tweaking of our process evolves.



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux