On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > The change replaces a custom implementation of .get_link_ksettings > callback with a shared phy_ethtool_get_link_ksettings(), note that > &priv->lock wrapping is not needed, because the lock does not > serialize access to phydev fields. No BUG() here, AFAICT. But then this is not a fix but an enhancement. And I would have done that in 2 steps: 1st removing the spinlock code and the 2nd removing the custom method implementation. > Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@xxxxxxxxxx> [...] MBR, Sergei
