Hi Marek,
On Wed, May 23, 2018 at 1:26 PM, Marek Vasut <marek.vasut@xxxxxxxxx> wrote:
> Add device tree bindings for the Dialog DA9063L. This is a
> variant of the DA9063 chip with smaller package, with less
> LDO regulators and without RTC block. The other properties
> of the chip are the same, including the content of the chip
> ID register.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Minor nit below.
> --- a/Documentation/devicetree/bindings/mfd/da9063.txt
> +++ b/Documentation/devicetree/bindings/mfd/da9063.txt
> @@ -6,14 +6,14 @@ Device Supply Names Description
> ------ ------------ -----------
> da9063-regulator : : LDOs & BUCKs
> da9063-onkey : : On Key
> -da9063-rtc : : Real-Time Clock
> +da9063-rtc : : Real-Time Clock (DA9063 only)
> da9063-watchdog : : Watchdog
>
> ======
>
> Required properties:
>
> -- compatible : Should be "dlg,da9063"
> +- compatible : Should be "dlg,da9063" or "dlg,da9063l"
> - reg : Specifies the I2C slave address (this defaults to 0x58 but it can be
> modified to match the chip's OTP settings).
> - interrupt-parent : Specifies the reference to the interrupt controller for
> @@ -23,8 +23,8 @@ Required properties:
>
> Sub-nodes:
>
> -- regulators : This node defines the settings for the LDOs and BUCKs. The
> - DA9063 regulators are bound using their names listed below:
> +- regulators : This node defines the settings for the LDOs and BUCKs.
> + The DA9063 regulators are bound using their names listed below:
>
> bcore1 : BUCK CORE1
> bcore2 : BUCK CORE2
> @@ -44,13 +44,28 @@ Sub-nodes:
> ldo10 : LDO_10
> ldo11 : LDO_11
>
> + The DA9063L regulators are bound using their names listed below:
> +
> + bcore1 : BUCK CORE1
> + bcore2 : BUCK CORE2
> + bpro : BUCK PRO
> + bmem : BUCK MEM
> + bio : BUCK IO
> + bperi : BUCK PERI
> + ldo3 : LDO_3
> + ldo7 : LDO_7
> + ldo8 : LDO_8
> + ldo9 : LDO_9
> + ldo11 : LDO_11
> +
As an alternative to having two lists, perhaps you can use a table, or
mark entries "(DA9063 only)", like you did for da9063-rtc above?
That makes it easier to see the differences.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
