On Sun, May 13, 2018 at 01:48:33PM +0200, Niklas Söderlund wrote: > Hi Simon, > > On 2018-05-13 10:19:13 +0200, Simon Horman wrote: > > On Fri, May 11, 2018 at 04:00:29PM +0200, Niklas Söderlund wrote: > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > > > --- > > > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 99 ++++++++++++++++++++--- > > > 1 file changed, 90 insertions(+), 9 deletions(-) > > > > > > Hi Simon, > > > > > > I have only tested i2c4 and the adv7482 which is connected there. But it > > > seemed silly to post this patch without enable all i2c as they are > > > according to the datasheet are the same as on H3 and M3-W. > > > > Thanks Niklas, > > > > I agree this makes sense. Do we have any way to test those nodes? > > Looking at the DT for M3-N the i2c busses used are i2c2 and i2c4. I > already verified i2c4 and for i2c2 it turned out some PFC parts where > missing, I just sent a patch for that [1]. Using that patch i2c2 also > successfully finds the devices described in DT. > > > If not I'm inclined to accept the patch without testing. > > I also think it would be OK for you to pickup this patch without testing > all the buses. > > 1. [PATCH] pinctrl: sh-pfc: r8a77965: Add I2C pin support Thanks, applied.