Hello, On Friday, 11 May 2018 16:45:16 EEST Simon Horman wrote: > On Fri, May 11, 2018 at 01:25:23PM +0200, Niklas Söderlund wrote: > > Hi Jacopo, > > > > Thanks for your work. > > > > On 2018-05-11 12:00:01 +0200, Jacopo Mondi wrote: > > > Describe VIN4 interface for R-Car D3 R8A77995 SoC. > > > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> > > > > Acked-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > > > >> --- > >> > >> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 11 +++++++++++ > >> 1 file changed, 11 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > >> b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index 82aed7e..bdf7017 > >> 100644 > >> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > >> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > >> @@ -783,6 +783,17 @@ > >> }; > >> }; > >> }; > >> + > >> + vin4: video@e6ef4000 { > >> + compatible = "renesas,vin-r8a77995"; > >> + reg = <0 0xe6ef4000 0 0x1000>; > >> + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; > >> + clocks = <&cpg CPG_MOD 807>; > >> + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > >> + resets = <&cpg 807>; > >> + renesas,id = <4>; > >> + status = "disabled"; > >> + }; > >> }; > > Thanks, I have moved the new node to preserve sorting of nodes by bus > address and applied the result. It is as follows: > > From: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> > Subject: [PATCH] arm64: dts: renesas: r8a77995: Add VIN4 > > Describe VIN4 interface for R-Car D3 R8A77995 SoC. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> > Acked-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > [simon: sorted node by bus address] > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index > ba98865b0c9b..2506f46293e8 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > @@ -610,6 +610,17 @@ > status = "disabled"; > }; > > + vin4: video@e6ef4000 { > + compatible = "renesas,vin-r8a77995"; > + reg = <0 0xe6ef4000 0 0x1000>; > + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 807>; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 807>; > + renesas,id = <4>; > + status = "disabled"; > + }; > + > ohci0: usb@ee080000 { > compatible = "generic-ohci"; > reg = <0 0xee080000 0 0x100>; -- Regards, Laurent Pinchart