Hi Jacopo, Thanks for your work. On 2018-05-11 12:00:38 +0200, Jacopo Mondi wrote: > Use the newly defined ${capture_vin} and ${convert_format} to generalize > capture operations from HDMI sources. > > Signed-off-by: Jacopo Mondi <jacopo@xxxxxxxxxx> > --- > yavta-hdmi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/yavta-hdmi b/yavta-hdmi > index a0a09a3..5806a0d 100755 > --- a/yavta-hdmi > +++ b/yavta-hdmi > @@ -11,10 +11,10 @@ out=/tmp/vin-tests > rm -fr $out > mkdir -p $out > > -size=$(v4l2-ctl --all -d /dev/$vin0 | awk '/Width/{print $3}' | tr '/' 'x') > +size=$(v4l2-ctl --all -d /dev/$capture_vin | awk '/Width/{print $3}' | tr '/' 'x') > > -yavta -n 4 --capture=10 /dev/$vin0 --file=$out/frame-#.bin $* > +yavta -n 4 --capture=10 /dev/$capture_vin --file=$out/frame-#.bin $* > > strings $out/frame*.bin | head | wc -l > md5sum $out/frame*.bin > -for f in $out/frame*.bin ; do $base/convert.sh $f $size ; done; > +for f in $out/frame*.bin ; do $base/convert.sh $f $size $convert_format; done; As stated before I don't like that $convert_format comes from board.sh but that it can be provided to convert.sh I do like. Acked-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > -- > 2.7.4 > -- Regards, Niklas Söderlund