Hello, 2018-05-02 17:14 GMT+09:00 Wolfram Sang <wsa@xxxxxxxxxxxxx>: > >> With the current state of the driver this patch should be fine, >> modulo the changes suggested above. But once HS400 support is merged >> some logic will be required to disable that feature for the r8a77965 >> until HS400 support for that SoC is explicitly added. >> >> Or conversely, perhaps when HS400 is added it should only be enabled >> in the driver for SoCs that are known to work: r8a7796 and r8a7795. In the >> case of the latter perhaps only ES2.0. >> >> Wolfram, what do you think? > > M3-N (and future SoCs as it seems) has 8 taps while the others have 4. > Maybe we should have something already in place to distinguish 8 taps > and 4 taps and leave the 8 taps part for "to be added later"? > Thanks for your review. I will drop .revision = "ES1.0" and renesas,sdhi-r8a77965 in V2. Best regards, Kaneko
