Hi Kaneko-san,
On Sun, Apr 29, 2018 at 9:48 PM, Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> wrote:
> From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
>
> This patch adds SDHI{0,1,2,3} pins, groups and functions to the R8A77965
> SoC.
>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx>
Thanks for your patch!
The pins, groups, and functions are correct, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>.
i.e. queuing in sh-pfc-for-v4.18, after fixing up the below.
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
> @@ -1923,6 +1923,264 @@ enum {
> RCAR_GP_PIN(6, 24), RCAR_GP_PIN(6, 25),
> };
>
> +/* - SDHI0 ------------------------------------------------------------------ */
> +static const unsigned int sdhi0_data1_pins[] = {
[...]
> +};
This doesn't belong in the middle of the usb0 section ;-)
> +
> static const unsigned int usb0_mux[] = {
> USB0_PWEN_MARK, USB0_OVC_MARK,
> };
> @@ -1997,6 +2255,32 @@ enum {
> SH_PFC_PIN_GROUP(usb0),
> SH_PFC_PIN_GROUP(usb1),
> SH_PFC_PIN_GROUP(usb30),
> + SH_PFC_PIN_GROUP(sdhi0_data1),
Alphabetical order, please.
> @@ -2083,6 +2367,44 @@ enum {
> "usb30",
> };
>
> +static const char * const sdhi0_groups[] = {
Alphabetical order, please.
> @@ -2096,6 +2418,10 @@ enum {
> SH_PFC_FUNCTION(usb0),
> SH_PFC_FUNCTION(usb1),
> SH_PFC_FUNCTION(usb30),
> + SH_PFC_FUNCTION(sdhi0),
> + SH_PFC_FUNCTION(sdhi1),
> + SH_PFC_FUNCTION(sdhi2),
> + SH_PFC_FUNCTION(sdhi3),
> };
Alphabetical order, please.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
