Hi Kieran, Thank you for the patch. On Monday, 30 April 2018 13:53:25 EEST Kieran Bingham wrote: > Commit 5d3b50d3c04d ("ARM: dts: renesas: r8a7790: Add FDP1 instances") > introduced the FDP1 for the r8a7790, but broke the sort ordering of the > device tree nodes. > > Move the last VSP up to it's peers to correct the ordering. > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > arch/arm/boot/dts/r8a7790.dtsi | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi > index c244aae7a026..b66a18af28f1 100644 > --- a/arch/arm/boot/dts/r8a7790.dtsi > +++ b/arch/arm/boot/dts/r8a7790.dtsi > @@ -1616,6 +1616,15 @@ > resets = <&cpg 128>; > }; > > + vsp@fe938000 { > + compatible = "renesas,vsp1"; > + reg = <0 0xfe938000 0 0x8000>; > + interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 127>; > + power-domains = <&sysc R8A7790_PD_ALWAYS_ON>; > + resets = <&cpg 127>; > + }; > + > fdp1@fe940000 { > compatible = "renesas,fdp1"; > reg = <0 0xfe940000 0 0x2400>; > @@ -1643,15 +1652,6 @@ > resets = <&cpg 117>; > }; > > - vsp@fe938000 { > - compatible = "renesas,vsp1"; > - reg = <0 0xfe938000 0 0x8000>; > - interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&cpg CPG_MOD 127>; > - power-domains = <&sysc R8A7790_PD_ALWAYS_ON>; > - resets = <&cpg 127>; > - }; > - > jpu: jpeg-codec@fe980000 { > compatible = "renesas,jpu-r8a7790", > "renesas,rcar-gen2-jpu"; -- Regards, Laurent Pinchart