Hi Laurent,
On 26/04/18 22:11, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Thursday, 26 April 2018 19:53:40 EEST Kieran Bingham wrote:
>> The r8a77965 has 4 VSP instances.
>>
>> Based on a similar patch of the R8A7796 device tree
>> by Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>.
>>
>> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
>> [Kieran: Rebased to top of tree, fixed sort orders]
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
>> ---
>> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 44 +++++++++++++++++++++++
>> 1 file changed, 44 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index
>> 1f44ed7c1b1c..e92e6b03333a 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> @@ -1009,6 +1009,17 @@
>> resets = <&cpg 615>;
>> };
>>
>> + vspb: vsp@fe960000 {
>> + compatible = "renesas,vsp2";
>> + reg = <0 0xfe960000 0 0x8000>;
>> + interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 626>;
>> + power-domains = <&sysc R8A77965_PD_A3VP>;
>> + resets = <&cpg 626>;
>> +
>> + renesas,fcp = <&fcpvb0>;
>> + };
>> +
>> fcpvb0: fcp@fe96f000 {
>> compatible = "renesas,fcpv";
>> reg = <0 0xfe96f000 0 0x200>;
>> @@ -1017,6 +1028,17 @@
>> resets = <&cpg 607>;
>> };
>>
>> + vspi0: vsp@fe9a0000 {
>> + compatible = "renesas,vsp2";
>> + reg = <0 0xfe9a0000 0 0x8000>;
>> + interrupts = <GIC_SPI 444 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 631>;
>> + power-domains = <&sysc R8A77965_PD_A3VP>;
>> + resets = <&cpg 631>;
>> +
>> + renesas,fcp = <&fcpvi0>;
>> + };
>> +
>> fcpvi0: fcp@fe9af000 {
>> compatible = "renesas,fcpv";
>> reg = <0 0xfe9af000 0 0x200>;
>> @@ -1025,6 +1047,17 @@
>> resets = <&cpg 611>;
>> };
>>
>> + vspd0: vsp@fea20000 {
>> + compatible = "renesas,vsp2";
>> + reg = <0 0xfea20000 0 0x4000>;
>
> RFP2 has a CLUT so the register range needs to be extended. I'd recommend
> covering the entire space (0x8000) even if no LUT or CLU module is present.
Ah yes, of course.
Updated.
>
>> + interrupts = <GIC_SPI 466 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 623>;
>> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
>> + resets = <&cpg 623>;
>> +
>> + renesas,fcp = <&fcpvd0>;
>> + };
>> +
>> fcpvd0: fcp@fea27000 {
>> compatible = "renesas,fcpv";
>> reg = <0 0xfea27000 0 0x200>;
>> @@ -1033,6 +1066,17 @@
>> resets = <&cpg 603>;
>> };
>>
>> + vspd1: vsp@fea28000 {
>> + compatible = "renesas,vsp2";
>> + reg = <0 0xfea28000 0 0x4000>;
>
> Same here.
>
And here...
> With this fixed,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Collected.
--
Kieran
>
>> + interrupts = <GIC_SPI 467 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 622>;
>> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
>> + resets = <&cpg 622>;
>> +
>> + renesas,fcp = <&fcpvd1>;
>> + };
>> +
>> fcpvd1: fcp@fea2f000 {
>> compatible = "renesas,fcpv";
>> reg = <0 0xfea2f000 0 0x200>;
>
>
