Hi Kieran,
Thank you for the patch.
On Thursday, 26 April 2018 19:53:41 EEST Kieran Bingham wrote:
> The DU entity node has been previously added but only as a placeholder.
> Populate the node with the properties to use the device.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index
> e92e6b03333a..8a40bba53027 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -1106,9 +1106,21 @@
> };
>
> du: display@feb00000 {
> + compatible = "renesas,du-r8a77965";
> reg = <0 0xfeb00000 0 0x80000>,
> <0 0xfeb90000 0 0x14>;
> - /* placeholder */
> + reg-names = "du", "lvds.0";
The LVDS encoder has been split to a separate node in current bindings. You
can remove the reg-names property and the second reg entry.
> + interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 724>,
> + <&cpg CPG_MOD 723>,
> + <&cpg CPG_MOD 721>,
> + <&cpg CPG_MOD 727>;
> + clock-names = "du.0", "du.1", "du.3", "lvds.0";
And you can remove the LVDS clock as well (from both clocks and clock-names).
With this fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> + status = "disabled";
> +
> + vsps = <&vspd0 0 &vspd1 0 &vspd0 1>;
>
> ports {
> #address-cells = <1>;
--
Regards,
Laurent Pinchart
