Hi Kieran, Thank you for the patch. On Tuesday, 24 April 2018 18:39:42 EEST Kieran Bingham wrote: > The symbol 'rcar_du_of_init' is defined by the rcar_du_of module header, > but it is not included by the C implementation. > > Include the header to correctly define the function prototypes. > > Fixes the following warning: > > linux/drivers/gpu/drm/rcar-du/rcar_du_of.c:319:13: > warning: symbol 'rcar_du_of_init' was not declared. Should it be static? > CC drivers/gpu/drm/rcar-du/rcar_du_of.o > > Fixes: 81c0e3dd8292 ("drm: rcar-du: Fix legacy DT to create LVDS encoder > nodes") Signed-off-by: Kieran Bingham > <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> and applied to my tree. > --- > drivers/gpu/drm/rcar-du/rcar_du_of.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_of.c > b/drivers/gpu/drm/rcar-du/rcar_du_of.c index 68a0b82cb17e..afef69669bb4 > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_of.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_of.c > @@ -18,6 +18,7 @@ > > #include "rcar_du_crtc.h" > #include "rcar_du_drv.h" > +#include "rcar_du_of.h" > > /* > --------------------------------------------------------------------------- > -- * Generic Overlay Handling -- Regards, Laurent Pinchart