Hello! On 04/24/2018 04:17 PM, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx> Acked-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> [...] > diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c > index b6b90a631..0875a169f 100644 > --- a/drivers/net/ethernet/renesas/sh_eth.c > +++ b/drivers/net/ethernet/renesas/sh_eth.c > @@ -2454,7 +2454,7 @@ static void sh_eth_tx_timeout(struct net_device *ndev) > } > > /* Packet transmit function */ > -static int sh_eth_start_xmit(struct sk_buff *skb, struct net_device *ndev) > +static netdev_tx_t sh_eth_start_xmit(struct sk_buff *skb, struct net_device *ndev) But aren't you violating 80-column limit? [...] MBR, Sergei
