On Tue, Apr 24, 2018 at 09:19:39AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Tue, Apr 24, 2018 at 9:08 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
> > On Fri, Apr 20, 2018 at 04:27:08PM +0100, Biju Das wrote:
> >> Describe SCIF ports in the R8A77470 device tree.
> >>
> >> Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> >> Reviewed-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> >> ---
> >> arch/arm/boot/dts/r8a77470.dtsi | 69 +++++++++++++++++++++++++++++++++++++++--
> >> 1 file changed, 67 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
> >> index 2f89f33..39549f2 100644
> >> --- a/arch/arm/boot/dts/r8a77470.dtsi
> >> +++ b/arch/arm/boot/dts/r8a77470.dtsi
> >> @@ -190,19 +190,84 @@
> >> dma-channels = <15>;
> >> };
> >>
> >> + scif0: serial@e6e60000 {
> >> + compatible = "renesas,scif-r8a77470",
> >> + "renesas,rcar-gen2-scif", "renesas,scif";
> >> + reg = <0 0xe6e60000 0 0x40>;
> >> + interrupts = <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
> >> + clocks = <&cpg CPG_MOD 721>,
> >> + <&cpg CPG_CORE 5>, <&scif_clk>;
> >> + clock-names = "fck", "brg_int", "scif_clk";
> >> + power-domains = <&sysc 32>;
> >> + resets = <&cpg 721>;
> >> + status = "disabled";
> >> + };
> >> +
> >> scif1: serial@e6e68000 {
> >> compatible = "renesas,scif-r8a77470",
> >> "renesas,rcar-gen2-scif", "renesas,scif";
> >> reg = <0 0xe6e68000 0 0x40>;
> >> interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>;
> >> - clocks = <&cpg CPG_MOD 720>,
> >> - <&cpg CPG_CORE 6>, <&scif_clk>;
> >> + clocks = <&cpg CPG_MOD 720>,
> >> + <&cpg CPG_CORE 5>, <&scif_clk>;
> >
> > I am a little unclear why the CPG clock is changed from 6 (ZS?) to 5 (ZX?).
> > Could you clarify this for me?
>
> #define R8A77470_CLK_ZS 5
>
> I guess you queued up the initial .dtsi before the error in
> include/dt-bindings/clock/r8a77470-cpg-mssr.h was detected?
Thanks, I see that ZS is 5 in renesas-drivers,
but when looking at an earlier version of the patch to add the
indexes it was 6.
I think that explains things. But could we add an explanation to the
changelog?
