Hi Wolfram-san, > From: Wolfram Sang, Sent: Friday, April 6, 2018 2:26 AM > > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > --- > > Only build tested. Fixed numerous times in other drivers, however... Thank you for the patch! Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> Best regards, Yoshihiro Shimoda > drivers/pwm/pwm-rcar.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/pwm/pwm-rcar.c b/drivers/pwm/pwm-rcar.c > index 91d11f2e2fef..748f614d5375 100644 > --- a/drivers/pwm/pwm-rcar.c > +++ b/drivers/pwm/pwm-rcar.c > @@ -261,8 +261,7 @@ MODULE_DEVICE_TABLE(of, rcar_pwm_of_table); > #ifdef CONFIG_PM_SLEEP > static struct pwm_device *rcar_pwm_dev_to_pwm_dev(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct rcar_pwm_chip *rcar_pwm = platform_get_drvdata(pdev); > + struct rcar_pwm_chip *rcar_pwm = dev_get_drvdata(dev); > struct pwm_chip *chip = &rcar_pwm->chip; > > return &chip->pwms[0]; > -- > 2.11.0