Hi Michel, On Thu, Mar 29, 2018 at 9:46 AM, Michel Pollet <michel.pollet@xxxxxxxxxxxxxx> wrote: > This documents the RZ/N1 bindings for both the RZ/N1 and the RZN1D-DB > board. > > Signed-off-by: Michel Pollet <michel.pollet@xxxxxxxxxxxxxx> Thanks for your patch! > --- a/Documentation/devicetree/bindings/arm/shmobile.txt > +++ b/Documentation/devicetree/bindings/arm/shmobile.txt > @@ -47,7 +47,10 @@ SoCs: > compatible = "renesas,r8a77980" > - R-Car D3 (R8A77995) > compatible = "renesas,r8a77995" > - > + - RZ/N1 Family (R9A06G032 & R9A06G033) > + compatible = "renesas,rzn1" > + - RZ/N1D (R9A06G032) > + compatible = "renesas,r9a06g032", "renesas,rzn1" Is there any value in the family-specific "renesas,rzn1" compatible value at the SoC level? We don't have them for other Renesas SoC families. We've been bitten before by values like "renesas,rspi-rz", not knowing at that time that Renesas was going to have multiple different RZ subfamilies. Compare also e.g. R-Car W2H with other R-Car Gen2 SoCs... Apart from that: Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds