On Thu, Mar 22, 2018 at 03:07:49PM +0900, Magnus Damm wrote: > Hi Simon, > > On Wed, Mar 21, 2018 at 6:57 PM, Simon Horman <horms@xxxxxxxxxxxx> wrote: > > On Wed, Mar 21, 2018 at 09:51:33AM +0100, Simon Horman wrote: > >> On Tue, Mar 20, 2018 at 04:51:07PM +0900, Magnus Damm wrote: > >> > From: Magnus Damm <damm+renesas@xxxxxxxxxxxxx> > >> > > >> > Judging by "R-Car-Gen3-rev0.80" IPMMU IMSSTR register documentation > >> > for [R-Car V3M] the DS1 bit field should be bit 0. > >> > > >> > Update the ipmmu-main property to make it match the data sheet. > >> > >> Thanks, I have confirmed this. Apologies for this error. > >> > >> AFIK this IP block is currently unused, I wonder if it, > >> ipmmu_mm and ipmmu_rt should have status = "disabled" added. > > > > Sorry, I take that back, I now see the nodes used elsewhere in > > the same DT file. > > Thanks for your help! My opinion is that for R-Car Gen3 we don't > really need to keep any IPMMU nodes in disabled state in DT. This > since the whitelist code in the IPMMU driver will include software > policy handling to during runtime make sure only desired devices get > enabled. Agreed
