Hi Geert,
Thanks for your work.
On 2018-03-12 15:40:16 +0100, Geert Uytterhoeven wrote:
> Hi all,
>
> On Renesas R-Car Gen2 SoCs, the pin group for the MDIO bus is named
> "mdio".
>
> When initial support was added for R-Car H3, the MDIO pin was forgotten,
> and the MDC pin got its own group named "mdc". During the addition of
> support for R-Car M3-W, this mistake was noticed. But as R-Car H3 and
> M3-W are pin compatible, and can be mounted on the same boards, the
> decision was made to just add the MDIO pin to the existing "mdc" group.
> Later this was extended to R-Car H3 ES2.0, and M3-N, because of pin
> compatibility, and to R-Car D3, in the name of consistency among R-Car
> Gen3 SoCs.
>
> However, this decision keeps on being questioned when adding new SoC
> support. Hence bite the bullet and admit our mistake, and rename the
> pin group from "mdc" to "mdio", like on R-Car Gen2 SoCs. Backwards
> compatibility with old DTBs is retained by using a pin group alias.
Thanks for fixing this, it frustrated me in the past :-) i like the pin
alias solution neat! For the whole series,
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
>
> This patch series:
> 1. Introduces a macro for creating pin group aliases,
> 2. Renames the "mdc" pin group to "mdio" on R-Car H3 (ES1.x and
> ES2.0), M3-W, M3-N, and D3.
>
> Thanks for your comments!
>
> Geert Uytterhoeven (6):
> pinctrl: sh-pfc: Add SH_PFC_PIN_GROUP_ALIAS()
> pinctrl: sh-pfc: r8a7795: Rename EtherAVB "mdc" pin group to "mdio"
> pinctrl: sh-pfc: r8a7795-es1: Rename EtherAVB "mdc" pin group to
> "mdio"
> pinctrl: sh-pfc: r8a7796: Rename EtherAVB "mdc" pin group to "mdio"
> pinctrl: sh-pfc: r8a77965: Rename EtherAVB "mdc" pin group to "mdio"
> pinctrl: sh-pfc: r8a77995: Rename EtherAVB "mdc" pin group to "mdio"
>
> drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c | 10 ++++++----
> drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 10 ++++++----
> drivers/pinctrl/sh-pfc/pfc-r8a7796.c | 10 ++++++----
> drivers/pinctrl/sh-pfc/pfc-r8a77965.c | 10 ++++++----
> drivers/pinctrl/sh-pfc/pfc-r8a77995.c | 10 ++++++----
> drivers/pinctrl/sh-pfc/sh_pfc.h | 5 +++--
> 6 files changed, 33 insertions(+), 22 deletions(-)
>
> --
> 2.7.4
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Regards,
Niklas Söderlund
