Hi Jacopo,
On 12/03/18 16:30, jacopo mondi wrote:
> Hi Kieran,
> just one small thing I noticed below...
>
> On Fri, Mar 09, 2018 at 10:04:07PM +0000, Kieran Bingham wrote:
>> VSPD and VSP-DL devices can provide extended display lists supporting
>> extended command display list objects.
>>
>> These extended commands require their own dma memory areas for a header
>> and body specific to the command type.
>>
>> Implement a command pool to allocate all necessary memory in a single
>> DMA allocation to reduce pressure on the TLB, and provide convenvient
>> re-usable command objects for the entities to utilise.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
>> ---
>> drivers/media/platform/vsp1/vsp1_dl.c | 189 +++++++++++++++++++++++++++-
>> drivers/media/platform/vsp1/vsp1_dl.h | 3 +-
>> 2 files changed, 192 insertions(+)
>>
>> diff --git a/drivers/media/platform/vsp1/vsp1_dl.c b/drivers/media/platform/vsp1/vsp1_dl.c
>> index 36440a2a2c8b..6d17b8bfa21c 100644
>> --- a/drivers/media/platform/vsp1/vsp1_dl.c
>> +++ b/drivers/media/platform/vsp1/vsp1_dl.c
>> @@ -121,6 +121,30 @@ struct vsp1_dl_body_pool {
>> };
>>
>> /**
>> + * struct vsp1_cmd_pool - display list body pool
>> + * @dma: DMA address of the entries
>> + * @size: size of the full DMA memory pool in bytes
>> + * @mem: CPU memory pointer for the pool
>> + * @bodies: Array of DLB structures for the pool
>> + * @free: List of free DLB entries
>> + * @lock: Protects the pool and free list
>> + * @vsp1: the VSP1 device
>> + */
>> +struct vsp1_dl_cmd_pool {
>> + /* DMA allocation */
>> + dma_addr_t dma;
>> + size_t size;
>> + void *mem;
>> +
>> + struct vsp1_dl_ext_cmd *cmds;
>> + struct list_head free;
>> +
>> + spinlock_t lock;
>> +
>> + struct vsp1_device *vsp1;
>> +};
>> +
>> +/**
>> * struct vsp1_dl_list - Display list
>> * @list: entry in the display list manager lists
>> * @dlm: the display list manager
>> @@ -176,6 +200,7 @@ struct vsp1_dl_manager {
>> struct vsp1_dl_list *pending;
>>
>> struct vsp1_dl_body_pool *pool;
>> + struct vsp1_dl_cmd_pool *autfld_cmds;
>> };
>>
>> /* -----------------------------------------------------------------------------
>> @@ -339,6 +364,139 @@ void vsp1_dl_body_write(struct vsp1_dl_body *dlb, u32 reg, u32 data)
>> }
>>
>> /* -----------------------------------------------------------------------------
>> + * Display List Extended Command Management
>> + */
>> +
>> +enum vsp1_extcmd_type {
>> + VSP1_EXTCMD_AUTODISP,
>> + VSP1_EXTCMD_AUTOFLD,
>> +};
>> +
>> +struct vsp1_extended_command_info {
>> + u16 opcode;
>> + size_t body_size;
>> +} vsp1_extended_commands[] = {
>> + [VSP1_EXTCMD_AUTODISP] = { 0x02, 96 },
>> + [VSP1_EXTCMD_AUTOFLD] = { 0x03, 160 },
>> +};
>
> How about making this one static and const, since it does not get
> modified?
Good spot. Certainly. This is just a static descriptor table of the extended
command parameter sizes, so it should not change. (but could be added to in
later hardware operations I presume).
Cheers
Kieran
>
> Thanks
> j
>
